-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress images #268
Progress images #268
Conversation
I think some cleanup could be done in the ImageUtil class. |
@brodeurlv do you have any feedback for me? |
Hi, I don't forget you. I have currently issues with compiling with the new
android studio. As soon as I can get it working I'll look at your PR.
Thanks.
Le dim. 24 sept. 2023, 18:32, FirstWithThisName ***@***.***>
a écrit :
… @brodeurlv <https://github.com/brodeurlv> do you have any feedback for me?
—
Reply to this email directly, view it on GitHub
<#268 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD65NDVQRXC7DHWCNJEC4C3X4BOC3ANCNFSM6AAAAAA422UNPU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. The code is clear and respect the current architecture. The import/export feature is also working well.
In term of features, I think only one usability feature is missing to make it complete:
- Possibility to change the date as you might want to import old pictures of yourself
Nice to have:
For this kind of feature, I would rather see a swipping on the picture part rather than buttons "newer/older".
And finally, I don't know if this is only me or not but the camera button doesn't launch the camera activity. DO you have the same issue on your side ?
Thank you @FirstWithThisName for the good work.
After just recompiling and installing I got the camera issue as well. Using the camera in other places fails as well, but in the f-droid version it is still working. |
Ok, the oldest version I can compile ba96637 has the issue as well. |
Hi @FirstWithThisName , sorry for the delayed answer. I guess it is a incompatibility issue between the crop-image and the android version. We would need to migrate it to the latests versions of the library. |
Add Progress images, Export and import can done via ZIP-Files.
See #177