Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress images #268

Merged
merged 7 commits into from
Nov 17, 2023
Merged

Conversation

FirstWithThisName
Copy link
Contributor

Add Progress images, Export and import can done via ZIP-Files.
See #177

@FirstWithThisName
Copy link
Contributor Author

I think some cleanup could be done in the ImageUtil class.
But I am uncertain if this the right place to do it.

@FirstWithThisName
Copy link
Contributor Author

@brodeurlv do you have any feedback for me?

@brodeurlv
Copy link
Owner

brodeurlv commented Sep 25, 2023 via email

@brodeurlv brodeurlv self-assigned this Sep 28, 2023
Copy link
Owner

@brodeurlv brodeurlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. The code is clear and respect the current architecture. The import/export feature is also working well.
In term of features, I think only one usability feature is missing to make it complete:

  • Possibility to change the date as you might want to import old pictures of yourself
    Nice to have:
    For this kind of feature, I would rather see a swipping on the picture part rather than buttons "newer/older".
    And finally, I don't know if this is only me or not but the camera button doesn't launch the camera activity. DO you have the same issue on your side ?

Thank you @FirstWithThisName for the good work.

@FirstWithThisName
Copy link
Contributor Author

FirstWithThisName commented Oct 3, 2023

After just recompiling and installing I got the camera issue as well.

Using the camera in other places fails as well, but in the f-droid version it is still working.
My guess it that oldschool method of stream copying broke something, but I am not quite certain yet.
Good that you noticed it.

@FirstWithThisName
Copy link
Contributor Author

Ok, the oldest version I can compile ba96637 has the issue as well.
So i think it is not an issue of the stream copying, but I am uncertain what the problem is I don't get usefull error messages.
@brodeurlv do you got an idea what the problem might be?

@brodeurlv
Copy link
Owner

Hi @FirstWithThisName , sorry for the delayed answer. I guess it is a incompatibility issue between the crop-image and the android version. We would need to migrate it to the latests versions of the library.

@brodeurlv brodeurlv merged commit 0c6a0f7 into brodeurlv:master Nov 17, 2023
@FirstWithThisName FirstWithThisName deleted the Progress-Images branch April 27, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants