Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI does not show the correct path of the generated library module #1

Closed
brodycj opened this issue Mar 3, 2019 · 0 comments
Closed

CLI does not show the correct path of the generated library module #1

brodycj opened this issue Mar 3, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@brodycj
Copy link
Owner

brodycj commented Mar 3, 2019

same as frostney/react-native-create-library#98
@brodycj brodycj added the bug Something isn't working label Mar 3, 2019
brodycj pushed a commit that referenced this issue Apr 3, 2019
correct module name from normalized-options.js
24756e1 
in output from the CLI

resolves #1

NOTE: There is a trick where the new normalizedOptions()
from normalized-options.js is applied by both command.js & lib.js.
This is to ensure that the CLI gets the correct module name for the
final log message, and that the exported programmatic
function can be completely tested from using the CLI.
@brodycj brodycj closed this as completed in fc46b36 Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brodycj