Issues/120: Use javaCompileProvider in Android template #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I will test this within the next week or so. My apologies for the delay. |
|
Merged with a merge commit. A big thank you to @cswagner, it should help quite a few people in the near term. I tested with example on React Native 0.59, 0.60, and 0.61 with installation from GitHub using the following command: npm i -g github:cswagner/create-react-native-module#issues/120with 100% success on Android. New release with this fix should be coming in the next few hours (at most). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #120
javaCompilewas deprecated in the Android Gradle plugin as of v3.3.0 in favor ofjavaCompileProviderto support lazy task configuration (see release notes).Since the Android Gradle plugin is currently configured in the template to v3.4.1 it's safe to just use
javaCompileProviderdirectly.