Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose full list of extensions for a mimetype #136

Closed

Conversation

loudwinston
Copy link

CHANGE SUMMARY

Update to provide new extensions method to expose full list of valid extensions for a mimetype. Existing extension method semantics are unchanged, so this should be fully backward compatible.

Documentation and tests are updated to reflect these changes.

@loudwinston
Copy link
Author

Can this be reviewed / merged? My team relies on these changes and we don't want to maintain our own branch in perpetuity.

@loudwinston
Copy link
Author

@broofa Can you please comment, merge, or close this PR? It's been open for 4 months now without any comments.

@dougwilson
Copy link

dougwilson commented Oct 18, 2016

So a similar API is being proposed to the mime-types module, but under the method name .allExtensions rather than .extensions. I'm sure there are a lot of folks subscribed to this repo, so are there any thoughts on the different names? Personally, I think .extensions() as in this PR seems the best, since it goes well with the .extension() API and keeps with the pattern of all current methods being lower-cased.

Thoughts?

@broofa
Copy link
Owner

broofa commented May 11, 2017

Sounds like mime-types module has this covered

@broofa broofa closed this May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants