Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got blank after press f when macOS system appearance is dark #1719

Closed
tshu-w opened this issue Apr 1, 2022 · 11 comments
Closed

Got blank after press f when macOS system appearance is dark #1719

tshu-w opened this issue Apr 1, 2022 · 11 comments

Comments

@tshu-w
Copy link

tshu-w commented Apr 1, 2022

Prelude

Both done.

Error details

SurfingKeys: 1.0.3

Browser: Safari 15.4 (17613.1.17.1.13) macOS 12.3.1

URL: Any like https://github.com/brookhong/Surfingkeys/issues

Context

When macOS system appearance is dark and I press f I got blank page.

macOS系统为 dark模式时(或者从 light 切换成 dark),按 f 页面空白。

Screen Shot 2022-04-01 at 19 26 32

@brookhong
Copy link
Owner

Can not reproduce this with 1.0.4.

image

@tshu-w
Copy link
Author

tshu-w commented Apr 9, 2022

Sorry, I find this only occurs when system switch appearance.
Here is the detailed step to reproduce it.

  1. Quit safari.
  2. change macOS system appearance to Light.
  3. open this issue Got blank after press f when macOS system appearance is dark #1719
  4. test f works fine now.
  5. change macOS system appearance to Dark.
  6. press f again and got the blank page.

BTW, I have disable all other extensions and github feature preview to avoid conflict.

@brookhong
Copy link
Owner

But I still can not reproduce this by following the exact steps above, could you try to upgrade to 1.0.4?

@tshu-w
Copy link
Author

tshu-w commented Apr 10, 2022

Hi, the latest version on App Store is 1.0.3?

@jmolero
Copy link

jmolero commented Apr 10, 2022

I'm using 1.0.4 and I have the same problem. I was able to fix it by setting color-scheme: light instead of auto in the SurfingKeys iframe. I hope that helps.

@tshu-w
Copy link
Author

tshu-w commented Apr 11, 2022

@jmolero Thanks you for your tips. However, I'm totally newbie for surfingkeys and css, it would be much appreciated if you could share your full config.

@jmolero
Copy link

jmolero commented Apr 11, 2022

I tried adding to the config but couldn't make it work. I think it is because this property is set in the div that wraps the SurfingKeys iframe. I hope this can be fixed. I inspected the CSS and this property was set to auto. Somewhere below it was set to dark, which makes it show the white page. If setting it to light it fixes the issue.

@tshu-w
Copy link
Author

tshu-w commented Jun 7, 2022

@brookhong Hi, I found the version on MAS is still 1.0.3. Would you mind update the version which make this ccedde8 take effect on macOS?

@brookhong
Copy link
Owner

brookhong commented Jun 18, 2022

@tshu-w If you can't download the latest version(currently 1.0.6), please see #1696, but I don't know how, please contact Apple for help.

@tshu-w
Copy link
Author

tshu-w commented Jun 19, 2022

@brookhong Hi, I download the new one and it works now.

@b0o
Copy link
Collaborator

b0o commented Nov 17, 2022

It would be nice if we could find a way to fix this issue without forcing the color scheme to be light, as this prevents users from creating light/dark mode themes in their custom configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants