Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need way to pass Escape through pass-through mode #908

Closed
aspiers opened this issue Jan 22, 2019 · 9 comments
Closed

need way to pass Escape through pass-through mode #908

aspiers opened this issue Jan 22, 2019 · 9 comments

Comments

@aspiers
Copy link
Contributor

aspiers commented Jan 22, 2019

When in pass-through mode, sometimes it's useful to be able to pass Escape through to the website. Example use case:

  • Go to a GitHub page
  • Press Alt-i to enable pass-through mode
  • Press ? to see the GitHub keyboard shortcuts modal dialog
  • Now I want to hide the GitHub dialog

However Escape simply cancels pass-through mode, so this is currently impossible. What seems to work instead is pressing Escape twice: the first cancels the mode, and the second somehow reaches the website. But of course then I have to press Alt-i to switch back into pass-through, which is not ideal.

SurfingKeys: 0.9.42

Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.84 Safari/537.36

@rstacruz
Copy link

Would alt-s (toggle SurfingKeys) work for this case? You can:

  • alt-s (Disable SurfingKeys)
  • ? (see GitHub keyboard shortcuts)
  • Esc (close GitHub dialog)
  • alt-s (Re-enable SurfingKeys)

@aspiers
Copy link
Contributor Author

aspiers commented Jan 23, 2019

Yes but it has the other disadvantages described here.

@brookhong
Copy link
Owner

Nice finding.

But the problem here is that SurfingKeys has no idea whether a Site has handled Esc or not.

@aspiers
Copy link
Contributor Author

aspiers commented Jan 23, 2019

I don't think SurfingKeys needs to know that, it would just need to provide a different way for passing Esc through. Then the user can use that when they need to.

@brookhong
Copy link
Owner

When in PassThrough mode, user presses Esc, currently it will quit PassThrough mode. If we need pass Esc through, we need know when we should pass it through and when we should just quit PassThrough mode. Another work-around here is we won't use Esc to quit PassThrough mode, but which will break the usual flow, as people are used to use Esc to escape from something.

@prestancedesign
Copy link

Maybe toggle PassThrough with the same keysAlt+i ?

@aspiers
Copy link
Contributor Author

aspiers commented Jan 24, 2019

@PrestanceDesign commented:

Maybe toggle PassThrough with the same keysAlt+i ?

Ahh, that's an interesting idea, but I agree with @brookhong that not everyone would expect or like this. So maybe make it an option whether PassThrough is exited via Esc or Alt+i? The default configuration would be the current behaviour, and people like me could reconfigure the exit key to be Alt+i instead of Esc.

@lkhphuc
Copy link

lkhphuc commented Jul 11, 2020

Having the same problem. Would be great if there is a way to change the exit Passthrough mode without the Escape key.

@brookhong
Copy link
Owner

Please try ephemeral Passthrough mode with p, see more at https://github.com/brookhong/Surfingkeys/blob/936284a3c4abd4c859b5157a5dd8f945671ba724/README.md#passthrough-mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants