Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get closest contiguous clickable element for hints to reduce duplicat… #1469

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quarkw
Copy link

@quarkw quarkw commented May 28, 2021

…e hints

Addresses #1448

SurfingKeys applies hints to any elements if they're clickable and visible. I modified SurfingKeys to find the furthest contiguous ancestor that is clickable. This significantly reduces duplicate hints, and should make it clearer what clickable region each hint actually refers to.

I experimented with deduplicating on the href, but that didn't seem to have much effect, and is excluded from this PR.

GMail hints

@quarkw
Copy link
Author

quarkw commented May 29, 2021

One issue with this implementation is that leaf elements can be swallowed up by the parent elements. An example of this is the per-email actions (star, selectbox on left side of each row)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant