Implement global hotkey for tab selector #547
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain websites (e.g. Gmail, Twitter, Remember the Milk, etc.) have their own keybindings which are kinda okay to use. However, if you turn off Surfingkey on them, you end up having no means of switching a tab via Surfingkey hotkey which is pretty annoying. So to get around this I had lots of following code in my config:
...which is of course a bit annoying and not very sustainable.
So I've added a global hotkey setting which would let you set a global hotkey to invoke the awesome tab selector regardless of Surfingkey being active on current page.
It's literally the first time I am commiting to a chrome extension, so let me know if it's hacky or anything, but I think I got it right.