Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape newline for BQ execution messages #362

Conversation

SPTKL
Copy link
Contributor

@SPTKL SPTKL commented Jun 20, 2023

Overview

Adding escape newline for BigQuery model/seed/snapshot/test executions
When there's an execution failure, BigQuery will produce multiline error messages, which will break dbt_artifacts, causing records not getting uploaded correctly.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

#361

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@SPTKL SPTKL had a problem deploying to Approve Integration Tests June 20, 2023 20:08 — with GitHub Actions Failure
@SPTKL SPTKL had a problem deploying to Approve Integration Tests June 20, 2023 20:08 — with GitHub Actions Failure
@SPTKL SPTKL had a problem deploying to Approve Integration Tests June 20, 2023 20:08 — with GitHub Actions Failure
@SPTKL SPTKL temporarily deployed to Approve Integration Tests June 20, 2023 20:08 — with GitHub Actions Inactive
@SPTKL SPTKL temporarily deployed to Approve Integration Tests June 20, 2023 20:08 — with GitHub Actions Inactive
@SPTKL SPTKL temporarily deployed to Approve Integration Tests June 20, 2023 20:09 — with GitHub Actions Inactive
@SPTKL SPTKL changed the title 361 escape newline bigquery executions Escape newline for BQ execution messages Jun 20, 2023
@SPTKL SPTKL temporarily deployed to Approve Integration Tests June 21, 2023 16:05 — with GitHub Actions Inactive
@SPTKL SPTKL temporarily deployed to Approve Integration Tests June 21, 2023 16:05 — with GitHub Actions Inactive
@SPTKL SPTKL temporarily deployed to Approve Integration Tests June 21, 2023 16:05 — with GitHub Actions Inactive
@SPTKL SPTKL temporarily deployed to Approve Integration Tests June 21, 2023 16:05 — with GitHub Actions Inactive
@SPTKL SPTKL temporarily deployed to Approve Integration Tests June 21, 2023 16:05 — with GitHub Actions Inactive
@SPTKL SPTKL temporarily deployed to Approve Integration Tests June 21, 2023 16:05 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer merged commit 135b1d4 into brooklyn-data:main Jun 21, 2023
@SPTKL SPTKL deleted the 361-escape-newline-bigquery-executions branch June 21, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants