Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Container does not stop #201

Closed
kroese opened this issue Mar 17, 2023 · 1 comment
Closed

[Bug]: Container does not stop #201

kroese opened this issue Mar 17, 2023 · 1 comment
Labels
bug Something isn't working fixed

Comments

@kroese
Copy link
Contributor

kroese commented Mar 17, 2023

Version

1.3.4

Node version

16.19.1

Operating System type

Linux

Operating system version

Ubuntu 22.10

Describe the bug

The container does not stop after receiving the stop-signal.

For most people this may not be so noticeable because after a 10 second timeout docker will just kill the container. But Im using a timeout of 240 seconds and so it takes multiple minutes for this container to be finally hard-killed by docker.

To reproduce

  1. docker stop -t=240 eufy-ws

Screenshots & Logfiles

The logfiles doesnt show anything about the shutdown process

Additional context

No response

@kroese kroese added the bug Something isn't working label Mar 17, 2023
@kroese kroese changed the title [Bug]: Container slow to stop [Bug]: Container does not stop Mar 18, 2023
@kroese
Copy link
Contributor Author

kroese commented Apr 10, 2023

I did some debugging, and found out that the code has nice HandleShutdown() functions, they are just not being called.

Further research indicated that is problem with how bash forwards the SIGTERM signal. It should be solved to modify the run.sh script to do:

exec /usr/local/bin/node

instead of just

/usr/local/bin/node

Could you please make this change because this problem is very annoying.

bropat added a commit that referenced this issue Apr 11, 2023
Updated dependency eufy-security-client to 2.4.3
Updated dependency fs-extra to 11.1.1
Updated dependency ws to 8.13.0
Updated dev dependencies
Updated docs
@bropat bropat added the fixed label Apr 11, 2023
@bropat bropat closed this as completed Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

2 participants