Support docker secrets for username and password #309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like confidential data just hanging around in environment variables, especially for security related products. That's what docker secrets were made for to make things a bit better.
With this PR you can use docker secrets to set the
USERNAME
andPASSWORD
usingUSERNAME_FILE
andPASSWORD_FILE
respectively. The files just contain the plaintext username or password. The traditional way of just usingUSERNAME
and/orPASSWORD
still works.A full docker compose example:
docker-compose.yml
$ cat eufy-security-ws_username
as an example