Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of _ssr_ prefix state fields #71

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

brophdawg11
Copy link
Owner

Adds support for stripping any Vuex SSR state fields that begin with _ssr_ so that we can use them for memoization of computationally expensive getters methods during SSR since reactvity is disabled during SSR:

https://ssr.vuejs.org/guide/universal.html#data-reactivity-on-the-server
vuejs/vue#10151

Copy link
Collaborator

@seriouslysean seriouslysean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be documented somewhere in the README outlining the purpose with a small use-case.

@brophdawg11
Copy link
Owner Author

@seriouslysean You are absolutely right - this repo is majorly lacking detailed documentation. It's still mostly the docs I wrote up from the original POC I did of this repo. I'm going to file a separate ticket to work on general overall documentation here

@seriouslysean
Copy link
Collaborator

@brophdawg11 all good, happy to help if needed 👍

@brophdawg11 brophdawg11 merged commit dfd4f3e into master Sep 14, 2020
@brophdawg11 brophdawg11 deleted the brophdawg11/ssr-getter-caching branch September 14, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants