-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix PsiTurk release location #351
Conversation
RobertGemmaJr
commented
Dec 8, 2023
- PsiTurk build is now uploaded to the GitHub release it belongs to
- The PsiTurk build is folder is zipped before being uploaded
Visit the preview URL for this PR (updated for commit c4a627a): https://ccv-honeycomb--pr351-ref-psiturk-release-938ozvdb.web.app (expires Mon, 18 Dec 2023 16:00:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
[This is my reminder to create a new release once this is merged to confirm the action works] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a whole bunch of reading on uploading artifacts 😵 Looks like you wanted to add the artifacts onto the tags !
Quick question:
So this action runs on
# Runs the build and package scripts when a new tagged release is publishe, created or edited
# Note that this runs for both releases and pre-releases: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
on:
release:
types: [created, edited, published]
I assume when a release is created, there is a tag that is also created?
Does in line 179 tag: ${{ github.ref }}
refer to the correct tag when the release is edited or published?
Commenting for now... with questions.
@eldu So, yes, our current instruction is for folks to create a new tag whenever a new release is created. |