Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix PsiTurk release location #351

Merged
merged 23 commits into from
Dec 12, 2023
Merged

fix: Fix PsiTurk release location #351

merged 23 commits into from
Dec 12, 2023

Conversation

RobertGemmaJr
Copy link
Member

  • PsiTurk build is now uploaded to the GitHub release it belongs to
  • The PsiTurk build is folder is zipped before being uploaded

@RobertGemmaJr RobertGemmaJr self-assigned this Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

Visit the preview URL for this PR (updated for commit c4a627a):

https://ccv-honeycomb--pr351-ref-psiturk-release-938ozvdb.web.app

(expires Mon, 18 Dec 2023 16:00:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

@RobertGemmaJr
Copy link
Member Author

[This is my reminder to create a new release once this is merged to confirm the action works]

@RobertGemmaJr RobertGemmaJr marked this pull request as ready for review December 8, 2023 19:33
Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a whole bunch of reading on uploading artifacts 😵 Looks like you wanted to add the artifacts onto the tags !

Quick question:

So this action runs on

# Runs the build and package scripts when a new tagged release is publishe, created or edited
# Note that this runs for both releases and pre-releases: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
on:
  release:
    types: [created, edited, published]

I assume when a release is created, there is a tag that is also created?

Does in line 179 tag: ${{ github.ref }} refer to the correct tag when the release is edited or published?

Commenting for now... with questions.

@RobertGemmaJr
Copy link
Member Author

I assume when a release is created, there is a tag that is also created?

Does in line 179 tag: ${{ github.ref }} refer to the correct tag when the release is edited or published?

@eldu So, yes, our current instruction is for folks to create a new tag whenever a new release is created. github.ref refers to the tag of the release that triggered the workflow. It will always refer to the correct release although tbh I'm unsure what it will do when file artifacts are already present in the release. I think it will overwrite naming conflicts but I haven't full tested that

Base automatically changed from ref-old-actions to main December 12, 2023 17:24
@RobertGemmaJr RobertGemmaJr merged commit 48ad25f into main Dec 12, 2023
8 checks passed
@RobertGemmaJr RobertGemmaJr deleted the ref-psiturk-release branch December 12, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants