ref: photodiodeGhostBox is always a part of the prompt
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also found a bug with the video trial which has been fixed (the ID's were mismatched) |
|
Visit the preview URL for this PR (updated for commit f3d57d3): https://ccv-honeycomb--pr378-ref-pd-stimulus-1kvkh07o.web.app (expires Wed, 17 Jan 2024 16:33:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
RobertGemmaJr
force-pushed
the
ref-pd-stimulus
branch
from
5324b96
to
f3d57d3
Compare
galenwinsor
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
The expected type of the
stimulusparameter changes based on the trial type whereas the prompt is always expected as an html string.cameratrialsstartCodeuses the photodiode correctlywelcomeuses the photodiode correctlyAll of the trials are now correctly showing the photodiode ghost box and flashing accordingly, yay! The hope is to move the photodiode functionality into a custom extension so the individual trials don't have to worry about these calls but that won't be until a v4
closes #372