Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Prefer function(){} instead of arrow functions #392

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

RobertGemmaJr
Copy link
Member

@RobertGemmaJr RobertGemmaJr commented Jan 30, 2024

The jsPsych documentation always uses the function syntax instead of arrow functions. It's a little more complicated code but I think matching the documentation will be better for folks.

  • Refactors the arrow functions for the event related callbacks to use function(){} syntax
  • Removes startKeypressListener utility function as it's unused

@RobertGemmaJr RobertGemmaJr self-assigned this Jan 30, 2024
Copy link

github-actions bot commented Jan 30, 2024

Visit the preview URL for this PR (updated for commit 91da192):

https://ccv-honeycomb--pr392-ref-arrow-functions-y1pf9yk9.web.app

(expires Tue, 06 Feb 2024 21:21:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

@RobertGemmaJr RobertGemmaJr added the 3.3 Versioning: Issue in regards to version 3.3 release label Feb 1, 2024
Base automatically changed from ref-exports to feat-v3.3 February 2, 2024 20:49
@RobertGemmaJr RobertGemmaJr merged commit 0de8d83 into feat-v3.3 Feb 2, 2024
8 checks passed
@RobertGemmaJr RobertGemmaJr deleted the ref-arrow-functions branch February 2, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3 Versioning: Issue in regards to version 3.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant