ref: Rename DEV_MODE as CONTINUE_ANYWAY
#434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 472eee2): https://ccv-honeycomb--pr434-ref-continue-anyway-n9ak36uq.web.app (expires Tue, 02 Apr 2024 18:57:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
RobertGemmaJr
added
electron
ref: Pull ELECTRON_START_URL into its own variable
eldu
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DEV_MODEflag is only true when the user elects "continue anyway" (e.g. for testing an experiment without the hardware explicitly connected. The rename toCONTINUE_ANYWAYbetter indicates the state of the application thoughDEV_MODEasCONTINUE_URLprocess.env.ELECTRON_START_URLinto its own variable