Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typedef.js in lib and update documentation in index.js to r… #504

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

YUUU23
Copy link
Contributor

@YUUU23 YUUU23 commented Jul 6, 2024

  • created typedef.js file in src/lib
  • moved JsPsych type from gearshift into this file
  • update eslint to include typedef.js
  • update documentation in index.js for buildTimeLine function from general object to JsPsych
    • should we in this same PR, update all these general object to JsPsych type for@param documentations for functions where it's applicable?

@YUUU23 YUUU23 self-assigned this Jul 6, 2024
Copy link

github-actions bot commented Jul 6, 2024

Visit the preview URL for this PR (updated for commit 2d3b804):

https://ccv-honeycomb--pr504-add-typedef-96fu5p7y.web.app

(expires Tue, 16 Jul 2024 03:31:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

@YUUU23 YUUU23 requested a review from RobertGemmaJr July 6, 2024 18:41
@YUUU23 YUUU23 linked an issue Jul 6, 2024 that may be closed by this pull request
@YUUU23 YUUU23 added the 3.4 Versioning: Issue in regards to version 3.4 release label Jul 6, 2024
Copy link
Member

@RobertGemmaJr RobertGemmaJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! I assume you did a sweep of other files in the project? There may be a few places where jsPsych {Object} is still being used. I'd do a quick check of that and then get this merged!

@YUUU23 YUUU23 merged commit f2cb44b into feat-v3.4.1 Jul 9, 2024
8 checks passed
@YUUU23 YUUU23 deleted the add-typedef branch July 9, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.4 Versioning: Issue in regards to version 3.4 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add typedef.js file from GearShift
2 participants