Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new branch with changes from original callFunction trial able to merg… #524

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

YUUU23
Copy link
Contributor

@YUUU23 YUUU23 commented Jul 31, 2024

Original code from #515

I messed up by forgetting that the callFunction should be added to 3.4.2 instead of 4.0 (so sorry about this!). This PR carry over those changes from the original PR but based on 3.4.2 instead of 4.0 so it can be merged more easily into this branch without too much changes.

@YUUU23 YUUU23 added the 3.4 Versioning: Issue in regards to version 3.4 release label Jul 31, 2024
@YUUU23 YUUU23 self-assigned this Jul 31, 2024
Copy link

Visit the preview URL for this PR (updated for commit b615053):

https://ccv-honeycomb--pr524-add-callfunction-3-4-xm27bewi.web.app

(expires Wed, 07 Aug 2024 21:43:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

@YUUU23 YUUU23 requested a review from RobertGemmaJr August 1, 2024 16:40
Copy link
Member

@RobertGemmaJr RobertGemmaJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@YUUU23 YUUU23 merged commit 51331a0 into feat-v3.4.2 Aug 1, 2024
8 checks passed
@YUUU23 YUUU23 deleted the add-callFunction-3.4.2 branch August 1, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.4 Versioning: Issue in regards to version 3.4 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants