Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix vite build configurations #525

Open
wants to merge 27 commits into
base: feat-v4
Choose a base branch
from
Open

Conversation

RobertGemmaJr
Copy link
Member

@RobertGemmaJr RobertGemmaJr commented Aug 2, 2024

I fixed the configurations here using CJS first. Once this is all set I'll switch back to type: "module"

  • Switches from ESM back to CJS
  • Adds a vite.browser.config.js - the configuration used when using Firebase in the browser
  • Adds a baseConfig in vite.base.config.js that serves as a base config for BOTH the browser and electron
  • The baseConfig is merged with the renderer config, not the forge config. This was the fix we needed!

Misc Changes

  • Little cleanup for eslint with the Firebase and the CLI script

@RobertGemmaJr RobertGemmaJr self-assigned this Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

Visit the preview URL for this PR (updated for commit 92e840b):

https://ccv-honeycomb--pr525-fix-make-cjs-rmlesfqr.web.app

(expires Wed, 14 Aug 2024 20:29:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

@RobertGemmaJr RobertGemmaJr requested review from eldu and YUUU23 August 2, 2024 16:59
@RobertGemmaJr RobertGemmaJr marked this pull request as ready for review August 2, 2024 17:00
@RobertGemmaJr RobertGemmaJr changed the base branch from fix-make-module to feat-v4 August 2, 2024 17:00
@RobertGemmaJr RobertGemmaJr changed the base branch from feat-v4 to build-deps August 2, 2024 17:03
Base automatically changed from build-deps to feat-v4 August 5, 2024 13:36
@RobertGemmaJr
Copy link
Member Author

Here's what I've discovered with the builds themselves:

  • osxSign: {} is ONLY needed with the universal builds, but will cause the build to crash on platform-specific builds
  • The universal build still needs "Open in Rosetta" to be checked off for some reason
  • The build for x64 seems to work fine on an arm mac anyways? Need to test that more
  • I also get a "Honeycomb Safe Storage" warning on mac when I go to run the application. I'm not entirely sure where that's coming from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants