Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add method to rate an album #379

Merged
merged 3 commits into from
Oct 9, 2021
Merged

feat: add method to rate an album #379

merged 3 commits into from
Oct 9, 2021

Conversation

browniebroke
Copy link
Owner

@browniebroke browniebroke commented Oct 9, 2021 •
edited
Loading

  • Include tests for bug fix and new functionality
  • Updated documentation for new feature

Fix #327

@codecov
Copy link

codecov bot commented Oct 9, 2021 •
edited
Loading

Codecov Report

Merging #379 (3d32491) into main (892b6b6) will decrease coverage by 6.20%.
The diff coverage is 67.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##              main     #379      +/-   ##
===========================================
- Coverage   100.00%   93.79%   -6.21%     
===========================================
  Files            4        5       +1     
  Lines          246      274      +28     
  Branches        23       27       +4     
===========================================
+ Hits           246      257      +11     
- Misses           0       16      +16     
- Partials         0        1       +1
Impacted Files Coverage Δ
deezer/exceptions.py 51.85% <51.85%> (ø)
deezer/client.py 95.95% <80.95%> (-4.05%) ⬇️
deezer/__init__.py 100.00% <100.00%> (ø)
deezer/resources.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1841a3d...3d32491. Read the comment docs.

@browniebroke browniebroke changed the title feat: basic structure to support POST method feat: add method to rate an album Oct 9, 2021
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 9, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.09%.

Quality metrics Before After Change
Complexity 0.84 ⭐ 0.88 ⭐ 0.04 👎
Method Length 28.94 ⭐ 28.85 ⭐ -0.09 👍
Working memory 4.35 ⭐ 4.38 ⭐ 0.03 👎
Quality 89.54% ⭐ 89.45% ⭐ -0.09% 👎
Other metrics Before After Change
Lines 1263 1322 59
Changed files Quality Before Quality After Quality Change
conftest.py 90.65% ⭐ 95.86% ⭐ 5.21% 👍
deezer/client.py 81.06% ⭐ 80.50% ⭐ -0.56% 👎
deezer/resources.py 94.91% ⭐ 94.93% ⭐ 0.02% 👍
tests/test_client.py 94.77% ⭐ 94.92% ⭐ 0.15% 👍
tests/test_resources.py 86.63% ⭐ 86.75% ⭐ 0.12% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
deezer/client.py Client.advanced_search 1 ⭐ 60 ⭐ 12 😞 70.27% 🙂 Extract out complex expressions
tests/test_client.py TestClient.test_process_json_types 0 ⭐ 140 😞 7 🙂 70.63% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@browniebroke browniebroke marked this pull request as ready for review October 9, 2021 16:43
@browniebroke browniebroke merged commit c8dc771 into main Oct 9, 2021
@browniebroke browniebroke deleted the feat/rate-album branch October 9, 2021 16:43
@browniebroke browniebroke mentioned this pull request Oct 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for POST/DELETE methods?
1 participant
@browniebroke