Replace usages of Client.get_object by Client.request

[browniebroke]

Most of the client methods use the get_object method internally:

deezer-python/deezer/client.py

Lines 156 to 174 in 59b0f57

	def get_object(
	self, object_t, object_id=None, relation=None, parent=None, **params
	):
	"""
	Actually query the Deezer API to retrieve the object.
	:returns: an :class:`~deezer.resources.Resource` or subclass.
	"""
	url = self.object_url(object_t, object_id, relation)
	params = params or {}
	if self.access_token is not None:
	params["access_token"] = str(self.access_token)
	response = self.session.get(url, params=params)
	json_data = response.json()
	if "error" in json_data:
	raise ValueError(
	f"API request return error for object: {object_t} id: {object_id}"
	)
	return self._process_json(json_data, parent)

In #379, the request method was added:

deezer-python/deezer/client.py

Lines 129 to 154 in 59b0f57

	def request(self, method: str, path: str, **params):
	"""
	Make a request to the API and parse the response.
	:param method: HTTP verb to use: GET, POST< DELETE, ...
	:param path: The path to make the API call to (e.g. 'artist/1234')
	:param params: Query parameters to add the the request
	:return:
	"""
	if self.access_token is not None:
	params["access_token"] = str(self.access_token)
	response = self.session.request(
	method,
	f"{self.base_url}/{path}",
	params=params,
	)
	try:
	response.raise_for_status()
	except requests.HTTPError as exc:
	raise DeezerHTTPError.from_http_error(exc) from exc
	json_data = response.json()
	if not isinstance(json_data, dict):
	return json_data
	if "error" in json_data:
	raise DeezerErrorResponse(json_data)
	return self._process_json(json_data)

They are very similar, but the request method is more versatile, we should aim to migrate all usages to the latter and eventually delete the get_object method.

[deepakdinesh1123]

Hi, can I take this issue?

[browniebroke]

Feel free to take it, yes. It might involve a good amount of repetitive changes.

Also, I realised that the 2 methods raise a slightly different exception in case of error so this would be a breaking change that will require a major version bump. We need to mark this change as such as explained in the conventioanl commits spec.