-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor existing methods to use newer request #394
Conversation
BREAKING CHANGE: A `DeezerErrorResponse` is now raised in case of error, instead of `ValueError`
BREAKING CHANGE: The `Client.get_genres` method has been removed and replaced by `Client.list_genres`
BREAKING CHANGE: The `Client.get_radios` method has been removed and replaced by `Client.list_radios`
bf5fc90
to
bd4be72
Compare
Codecov Report
@@ Coverage Diff @@
## main #394 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 298 310 +12
Branches 27 31 +4
=========================================
+ Hits 298 310 +12
Continue to review full report at Codecov.
|
BREAKING CHANGE: The `get_object`, `object_url` and `url` methods have been removed from the `Client` and `AsyncClient` classes
BREAKING CHANGE: the `advanced_search` method no longer exists and has been merged into the regular `search` method.
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.18%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Impacted issues:
Client.get_object
byClient.request
- fix Replace usages ofClient.get_object
byClient.request
#383Summary of changes:
request
request
request
and work with itComment