-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: build docs using Python 3.12 #935
Conversation
browniebroke
commented
Feb 17, 2024
- Include tests for bug fix and new functionality
- Updated documentation for new feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Enhancement
PR Summary: The pull request aims to update the build environment for documentation by upgrading to Ubuntu 22.04 and using Python 3.12. This change is intended to ensure that the documentation build process uses the most up-to-date software versions, potentially leveraging new features and improvements.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- It's crucial to verify the Python version specified in the PR. Python 3.12 has been mentioned, but as of the last known information, Python 3.12 has not been officially released. This could lead to compatibility issues or build failures. Consider using the latest officially released version of Python.
- Ensure that all dependencies and the build process itself are fully compatible with Ubuntu 22.04 and the specified Python version. It might require testing or updating dependencies to avoid any unforeseen issues.
- Given the nature of the changes, it would be beneficial to include a brief rationale in the PR description for choosing Ubuntu 22.04 and Python 3.12 specifically. This can help in understanding the benefits of these upgrades and ensure that they align with the project's needs.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
tools: | ||
python: "3.9" | ||
python: "3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (llm): Python 3.12 is not yet released. This version specification might be a typo or an anticipation of future releases. Please confirm the intended Python version for compatibility.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 19 19
Lines 715 715
Branches 54 54
=======================================
Hits 714 714
Partials 1 1 ☔ View full report in Codecov by Sentry. |