Anchor sound #1500
Open
Anchor sound #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle absolute as well as relative paths (issue brownplt#969)
This isn't user-facing, but avoids us getting npm CRITICAL SECURITY errors because a tester has an old dependency. It also has the happy consequence of simplifying some of the parse-test configuration.
[Reported via email] In the implementation of the algorithm for reassigning TRO parameters, j-vars were mixed with j-assigns, which is a type error. There was no test for this case, which has been added. The algorithm is fine as far as I can tell and test, it just needed to return JStmts, not JExprs, and do the wrapping internally for the j-assigns rather than leaving that work until later.
``` import lists as L #| |# # ``` This code was using the wrong signature for `makeWSToken`, so it wasn't passing in the correct srcloc positions. (Thanks to Yanyan for finding this bug.)
Fixing a very strange bug in the tokenizer for certain programs
…ms, which causes exceptions rather than reporting the compile errors [fixes brownplt#1332, fixes brownplt#1013, fixes brownplt#815] Co-authored-by: Ben Lerner <blerner@users.noreply.github.com>
…ext to have all the relevant information
… up stats library
Fixes brownplt#1480. Currently, octal escape sequences are parsed incorrectly because the sequence is evaluated only partially. The "\" delimiter in an octal sequence like "\101" is already siphoned off during escape sequence matching, so it is enough to simply parse the match of the numeric sequence "101".
fix: properly parse octal escape sequences
…g into anchor-sound
…g into anchor-sound
…g into anchor-sound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete Pull