-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[CI] install stable chrome #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Greptile OverviewGreptile SummaryAdded step to install stable Chrome before running local E2E tests in CI. The new step fetches the latest stable Chrome version from chrome-for-testing API, downloads and installs it to
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant GHA as GitHub Actions
participant API as Chrome for Testing API
participant Storage as Google Storage
participant ENV as Environment
participant Tests as E2E Tests
GHA->>API: Fetch last-known-good-versions.json
API-->>GHA: Return stable Chrome version
GHA->>Storage: Download chrome-linux64.zip
Storage-->>GHA: Return Chrome binary
GHA->>GHA: Unzip to $RUNNER_TEMP/chrome-stable
GHA->>GHA: chmod +x chrome binary
GHA->>ENV: Set CHROME_PATH=$CHROME_BIN
GHA->>Tests: Run pnpm run e2e:local
Tests->>ENV: chrome-launcher reads CHROME_PATH
Tests->>Tests: Launch Chrome and execute tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
| set -euo pipefail | ||
| CHROME_VERSION=$(curl -s https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json | jq -r '.channels.Stable.version') | ||
| DOWNLOAD_URL="https://storage.googleapis.com/chrome-for-testing-public/${CHROME_VERSION}/linux64/chrome-linux64.zip" | ||
| INSTALL_DIR="${RUNNER_TEMP}/chrome-stable" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can save a bit of time on all tests by caching this dir in github actions cache but not critical for now (using OS, arch, and chrome version in cache key)
why
what changed
ci.ymlshadow-frame.spec.ts