-
Notifications
You must be signed in to change notification settings - Fork 1.3k
bump version #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump version #1310
Conversation
|
Greptile OverviewGreptile SummaryBumps version from 3.0.4 to 3.0.5 in preparation for next release containing Fara 7B support.
Recommendation: Use Confidence Score: 2/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant PR as This PR
participant CS as Changesets
participant NPM as NPM Registry
Note over Dev,CS: Current Approach (Manual)
Dev->>PR: Manually edit package.json to 3.0.5
PR->>NPM: Merge & publish
Note over CS: ❌ CHANGELOG.md not updated
Note over CS: ❌ .changeset/free-dancers-rescue.md still exists
Note over CS: ❌ evals package.json not bumped
Note over Dev,CS: Recommended Approach (Changesets)
Dev->>CS: Run `pnpm changeset version`
CS->>PR: Update package.json to 3.0.5
CS->>PR: Update CHANGELOG.md with Fara 7B entry
CS->>PR: Remove .changeset/free-dancers-rescue.md
CS->>PR: Bump evals package.json to 1.1.5
PR->>NPM: Merge & publish
Note over NPM: ✅ All files consistent
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| { | ||
| "name": "@browserbasehq/stagehand", | ||
| "version": "3.0.4", | ||
| "version": "3.0.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: manual version bump bypasses changeset workflow - should run pnpm changeset version to also update CHANGELOG.md and remove .changeset/free-dancers-rescue.md
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/core/package.json
Line: 3:3
Comment:
**logic:** manual version bump bypasses changeset workflow - should run `pnpm changeset version` to also update CHANGELOG.md and remove `.changeset/free-dancers-rescue.md`
How can I resolve this? If you propose a fix, please make it concise.
why
bump version to 3.0.5
what changed
our package.json is out of sync with latest release version
test plan