Skip to content

resolve updates #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Feb 17, 2015 · 3 comments
Closed

resolve updates #56

ghost opened this issue Feb 17, 2015 · 3 comments

Comments

@ghost
Copy link

ghost commented Feb 17, 2015

I just fixed some very tricky issues in resolve that were cropping up in browserify and are now part of the test suite. I recommend upgrading to 1.1.3, since the current tests fail when browser-resolve uses the old version.

The updates address some errors with the previous opts.pathFilter implementation and some very subtle bugs when there is a ./file.js and a ./file directory.

@ghost
Copy link
Author

ghost commented Feb 18, 2015

Upgrading appears to breaks one of the browser-resolve tests. I'll iterate on resolve to see if I can get everything to pass.

@ghost
Copy link
Author

ghost commented Feb 21, 2015

All fixed in 1.1.4. I also noticed in the current browser-resolve implementation that a package.json of:

{
  "browser": {
    "xyz": "wow.js"
  }
}

does not work for require('foo/xyz') but this does:

{
  "browser": {
    "./xyz": "wow.js"
  }
}

This is because internally a ./ is prepended in the pathFilter. This is something that can be handled later in a patch, but everything is ready to go right now.

@ghost
Copy link
Author

ghost commented Feb 21, 2015

Just published under 1.7.1. The only change was upgrading resolve to 1.1.4.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants