You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that if resolving a path that matches the regexp
e.g. ./node_modules/jquery/jquery.min - then loadAsFile(String, Function) is called
however if the id takes format of "jquery/jquery.min", then loadAsFile(String, undefined, Function) is called
This results in opts.package being used only when the RegExp is matched. This has an upstream effect on browser-resolve and module-deps whereby if I use the first format, my transforms will apply inside of node_modules, but if I use the second, they don't... is this possibly a bug, or is there a reason behind it? Thanks!
The text was updated successfully, but these errors were encountered:
@jaredhanson any thoughts on this one? I had a look at the changeset and it looks like it was a conscious choice to send undefined as 2nd param if id does not match regexp.
I'm not sure what's specifically actionable here, so I'm going to close it, but I'm more than happy to reopen it if there's something specific we should be doing.
It seems that if resolving a path that matches the regexp
e.g. ./node_modules/jquery/jquery.min - then loadAsFile(String, Function) is called
however if the id takes format of "jquery/jquery.min", then loadAsFile(String, undefined, Function) is called
This results in opts.package being used only when the RegExp is matched. This has an upstream effect on browser-resolve and module-deps whereby if I use the first format, my transforms will apply inside of node_modules, but if I use the second, they don't... is this possibly a bug, or is there a reason behind it? Thanks!
The text was updated successfully, but these errors were encountered: