update sha* alg definitions #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok so the key test would be one that
|
omsmith
commented
May 31, 2018
|
|
||
| t.ok(nCrypto.createVerify(f.scheme).update(message).verify(pub, nSig), 'node validate node sig') | ||
| t.ok(nCrypto.createVerify(f.scheme).update(message).verify(pub, bSig), 'node validate browser sig') | ||
| t.equals(nSig.toString('hex'), f.signature, 'node compare to known') |
There was a problem hiding this comment.
Tests were failing before I added the id/tag to the other definitions, so I added this as a sanity check. This was consistently "OK", meaning node was doing the expected thing.
There was a problem hiding this comment.
ok this is a good check
omsmith
commented
May 31, 2018
| "hash": "sha256", | ||
| "id": "" | ||
| "id": "3031300d060960864801650304020105000420" |
There was a problem hiding this comment.
Added these to get RSA going, which is the only thing it impacts (as I'm sure you know). Although, it is a little weird to do
There was a problem hiding this comment.
yeah this file was just set up before I latter learned how weird some of the names were handled in node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on updating the test fixtures to codify it, but do believe these should all support both ecdsa and rsa. Should be the "correct" ones to use vs the "RSA-SHA*" aliases.
Ref: auth0/node-jwa#26