-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] v2.0.0 (only ciphers, not hashes) #3
base: master
Are you sure you want to change the base?
Conversation
default encoding should be |
in node the cipher and cipheriv are based on each other so there isn't really much need for a separate. Also some of these changes are things that probably seem clearer to you, but seam less clear to me and are probably overall exactly the same clarity wise. These add some needless churn to the diff so could you separate out the more stylistic changes from the functional ones so I can review them separately? We should also probably update the default encoding in a sperate pull because that is probably what's hosing the tests. (was on vacation last week, then got really sick wtihin hours of getting home this week so am still digging out) |
f6c8fef
to
634c57c
Compare
634c57c
to
f028276
Compare
f028276
to
edb41a7
Compare
Updated. |
@dcousens if I remember correctly this WIP because we decide wait until 0.12 will out of support? you free to change or create new PR based on this |
OK, |
I think yes, but |
@calvinmetcalf can you check code before tests?
It is not simply removing because I want strict following by node crypto. Is CipherBase/CipherivBase/.. good decision?