Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notice about browser support. #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add notice about browser support. #45

wants to merge 2 commits into from

Conversation

goto-bus-stop
Copy link
Member

No description provided.

BridgeAR
BridgeAR reviewed May 10, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only true for the current version. As soon as the next major is released, only IE 11 will be tested for.

@BridgeAR
Copy link
Member

@goto-bus-stop this needs a rebase.

@BridgeAR BridgeAR added the WIP Work in progress label May 12, 2019
@lukechilds
Copy link
Member

Oops, sorry, I forgot to add a note in the readme for v2.0.0 about IE11 support which requires a Promise polyfill.

I would suggest the wording:

assert supports modern browsers and also Internet Explorer 11 when a Promise polyfill is supplied.

Shall I add this now?

Also, should I do another minor release and publish so the notification is visible on the npmjs.com page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

Assignees
No one assigned
Labels
WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goto-bus-stop @BridgeAR @lukechilds