reconstruct outputs every addHooks (to make it compatible with watchify)
#71
Conversation
jcppman
changed the title
addHooks
jcppman
changed the title
addHooksaddHooks (to make it compatible with watchify)
|
Thanks @jcppman for this patch. However this guy does not work for the case where outputs is an array of streams. I think we may need something like this to fix the issue https://github.com/Aben/factor-bundle/commit/18692d69d983470857d6d3c6af7b7bd12266714f |
- To avoid writing to ended writeStream, outputs will be constructed everytime - In the scenario that user wanna use outpipe, the `outopt` will be kept as string, so we can determine the user's attempt in later codes and do the relavant opperations
sorry, the previous location is better
|
added two tests which will fail before applying the patch and will success after applying the patch |
|
In my opinion https://github.com/Aben/factor-bundle/commit/18692d69d983470857d6d3c6af7b7bd12266714f is more of a workaround to skip the part that cause the issue (write to end stream). BTW how about three-ways merging instead of copy-and-paste? I mean, I'm not quite care if i got my name on the commit or not but i guess that's the way open-sourced things work right? |
|
Sorry u are right. did not mean to side step credit. will do the merge in the future. Thx for vocalizing. Just want to make sure the stream case is covered as we need it. If there is a better way then let's do it that way |
|
@dgbeck No worry, I'm glad that it's useful to other ppl not just me! |
|
all sorted in the 2.5.0 release |
ghost
closed this
|
Fantastic! |
fix #68, #63
outoptwill bekept as string, so we can determine the user's attempt in later codes
and do the relavant opperations