Skip to content

Support res.setEncoding and non-text response types #21

@wmrowan

Description

@wmrowan

Response data in http-browserify seems to default to text. In node http it seems to default to buffer. Independent of defaults, the node version supports setEncoding so you can change the type of the response. The browserify version should do the same.

Activity

Jxck

Jxck commented on Sep 9, 2014

@Jxck

+1
or support only setEncoding('utf8') and ignore others seems fine.

tellnes

tellnes commented on Sep 9, 2014

@tellnes
Contributor

See #10

MiguelCastillo

MiguelCastillo commented on Sep 9, 2014

@MiguelCastillo

So, is there a plan to merge the PR?

jamestalmage

jamestalmage commented on Jun 30, 2015

@jamestalmage

Would there be any value to throwing or at least logging an error if it is not utf-8?

+1 either way.

added a commit that references this issue on Jun 30, 2015
jstoeffler

jstoeffler commented on Apr 17, 2016

@jstoeffler

+1

drawm

drawm commented on Sep 23, 2016

@drawm

+1
Causes problem on other library.
baalexander/node-xmlrpc#135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @Jxck@tellnes@wmrowan@MiguelCastillo@jstoeffler

      Issue actions

        Support `res.setEncoding` and non-text response types · Issue #21 · browserify/http-browserify