-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util.deprecate causes a stack overflow in browser #11
Comments
bernardmcmanus
added a commit
to bernardmcmanus/node-util
that referenced
this issue
Mar 30, 2016
bernardmcmanus
added a commit
to bernardmcmanus/node-util
that referenced
this issue
Oct 31, 2018
goto-bus-stop
added a commit
that referenced
this issue
Nov 1, 2018
Resolved by #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When
util.js
is bundled with browserify and run in browser,util.deprecate
falls into an infinite loop here becauseprocess
is not namespaced toglobal
- it's only global within the context of the browserify bundle.I can see where this would fall to @substack considering this deviates from the node environment, but I can also see why they would not want to set
window.process
from within a bundle. Checkingtypeof process
rather thanisUndefined(global.process)
would be a simple solution.Regardless, the
--no-deprecation
check should occur first to provide a way to avoid this.Demo here.
The text was updated successfully, but these errors were encountered: