Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen semver for inherits #39

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Loosen semver for inherits #39

merged 1 commit into from
Jul 5, 2019

Conversation

snyamathi
Copy link
Contributor

@goto-bus-stop https://github.com/isaacs/inherits has been updated with a patch fix and while some of our client side packages have picked up this newer version, this package is locked to the older version.

This ends up bloating our client side js since we have duplicate versions of inherits if any package specifies ^2.0.4 ( although you could make the case that they could loosen their semver to accept ^2.0.3 ).

isaacs/inherits@v2.0.3...v2.0.4

Can we loosen the semver requirement on inherits so that we don't have this issue? Thanks!

@snyamathi
Copy link
Contributor Author

@goto-bus-stop alternatively we could just pin the version at 2.0.4 if that's preferred. Let me know and I can update this PR to reflect that.

Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! this seems OK for now, but perhaps util.inherits should use a different package, if inherits is not actually strictly a util.inherits polyfill. In Node.js, not passing in a superclass deliberately throws an error.

If you rely on this behaviour make sure to only access it through require('inherits'), because util.inherits is not supposed to support it and it might change in a later version!

@snyamathi
Copy link
Contributor Author

@goto-bus-stop anything else you need from my end to get this merged and published?

@goto-bus-stop goto-bus-stop merged commit 276db51 into browserify:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants