-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE 11 compatibility when Symbol is polyfilled #47
IE 11 compatibility when Symbol is polyfilled #47
Conversation
0fa099e
to
4068972
Compare
I'm not sure if the Sauce Labs tests are running correctly. I forgot to update this: Using a non-existent script should result in a non-zero exit code, but Travis seems to have passed: https://travis-ci.org/github/browserify/node-util/builds/681196592 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a clean semver-patch that makes these checks go from "not particularly robust" to "as unbreakable as i know to be possible" :-)
i'm obviously a bit biased, so this should get more eyes before landing.
This looks good to me! I wish I'd known about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saucelabs tests don't run on pull requests—pushed a branch to trigger a full run here: https://travis-ci.org/github/browserify/node-util/jobs/681393138
Will merge once that comes up green. Thanks for working on this!
Resolves #40.
Currently, with a Symbol polyfill present in IE 11, requiring
util/types
throws (see #40 for more detail). WithSymbol
andSymbol.toStringTag
available, IE 11 then attempts to use it on the Uint8Array prototype, where it does not exist.This:
is-typed-array
andwhich-typed-array
to determine if values are typed arrays and which type they are.Ideally this is published in a patch release or https://github.com/browserify/commonjs-assert is updated to use it, as folks seem to run into this through their use of
assert
(though it's certainly possible to useutil/types
directly).cc @mischnic @devongovett @padmaia @stacylondon
Test Plan: Ran both sets of tests (with and without polyfills) in IE 11 with success.