Update asn1.js #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so this isn't stricly needed except to prevent weird cache issues, but doesn't hurt |
|
I had to unpublish this as it causes an peer invalid error, ping me when its safe to publish again |
|
The peer dependency conflict will exist so long as bn.js 0.15 is a peer dependency is in the same tree. The way around this would be to bump the major. |
|
bump the major where? I thought we were just waiting on indutny/asn1.js#32 to upgrade? |
|
Ahh right, sorry I thought you meant the bn.js 0.15 peer dependency issue was still happening, but of course that's been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for all the help getting these through. Still ironing out the bn.js fork here.
See indutny/asn1.js#32 as well.