Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .npmignore #149

Closed
wants to merge 1 commit into from
Closed

Create .npmignore #149

wants to merge 1 commit into from

Conversation

eugenelim
Copy link

Remove test/ folder from being published with the npm package

Remove test/ folder from being published with the npm package
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentionally included; npm explore foo && npm install && nom test should always work.

@ljharb ljharb closed this Feb 15, 2018
@eugenelim
Copy link
Author

Shouldn't npm test only be available if you git clone the repo instead of pulling down the test/ folder as part of an npm install?

@ljharb
Copy link
Member

ljharb commented Feb 15, 2018

No. If should be available on any install, to handle later offline debugging use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants