Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: resolve result is inconsistent with require.resolve if windows virtual drive is used #284

Merged
merged 1 commit into from
May 31, 2022

Conversation

pos777
Copy link
Contributor

@pos777 pos777 commented May 23, 2022

appveyor.yml Show resolved Hide resolved
@ljharb ljharb force-pushed the fix-vdrive-windows-path branch 2 times, most recently from febb9d3 to 0008477 Compare May 31, 2022 21:22
@ljharb ljharb merged commit 0008477 into browserify:1.x May 31, 2022
@pos777 pos777 deleted the fix-vdrive-windows-path branch June 1, 2022 06:44
ljharb added a commit that referenced this pull request Jun 17, 2022
 - [Fix] support windows virtual drive paths (#284)
 - [Deps] update `is-core-module`
 - [meta] use `npmignore` to autogenerate an npmignore file
 - [meta] do not publish `appveyor.yml`
 - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `tape`
 - [Test] add tests for `"main": false`
 - [Tests] fix tests on node v12.0-12.2
 - [Test] add some `sync` coverage
 - [Test] fix incorrect `require.resolve` paths logic; enable these tests
 - [Tests] avoid tests breaking on node 11.11 - 11.13
ljharb added a commit that referenced this pull request Jun 17, 2022
v1.22.1

 - [Fix] support windows virtual drive paths (#284)
 - [Deps] update `is-core-module`
 - [meta] use `npmignore` to autogenerate an npmignore file
 - [meta] do not publish `appveyor.yml`
 - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `tape`
 - [Test] add tests for `"main": false`
 - [Tests] fix tests on node v12.0-12.2
 - [Test] add some `sync` coverage
 - [Test] fix incorrect `require.resolve` paths logic; enable these tests
 - [Tests] avoid tests breaking on node 11.11 - 11.13
ljharb added a commit that referenced this pull request Jun 18, 2022
Changes since v2.0.0-next.3:

 - [Breaking] ignore `SyntaxError`s from `readPackage`/`readPackageSync`,  eg due to a malformed package.json

Including all changes in v1.20.0 - v1.22.1:

v1.22.1

 - [Fix] support windows virtual drive paths (#284)
 - [Deps] update `is-core-module`
 - [meta] use `npmignore` to autogenerate an npmignore file
 - [meta] do not publish `appveyor.yml`
 - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `tape`
 - [Test] add tests for `"main": false`
 - [Tests] fix tests on node v12.0-12.2
 - [Test] add some `sync` coverage
 - [Test] fix incorrect `require.resolve` paths logic; enable these tests
 - [Tests] avoid tests breaking on node 11.11 - 11.13

v1.22.0

 - [New] add default support for `paths` to include `$HOME/.node_{modules,libraries}` (#273)
 - [Deps] update `is-core-module`

v1.21.1

 - [Fix] `bin/resolve`: allow `npx resolve` usage
 - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `aud`, `tape`
 - [Tests] add tests comparing `resolve.sync` to `require.resolve`

v1.21.0

 - [New] add top-level granular entry points
 - [New] add simple CLI util (#94)
 - [Refactor] `sync`: Do not throw on missing files in `isFile`/`isDirectory` (#256)
 - [Deps] update `is-core-module`, `path-parse`
 - [readme] pull in changes from default branch
 - [readme] remove defunct travis badge; update badges
 - [meta] backport FUNDING.yml
 - [meta] skip deleted files in `eclint` check
 - [meta] use `prepublishOnly`, for npm 7+
 - [actions] reuse common workflows
 - [actions] pull in workflows from default branch
 - [actions] use `node/install` instead of `node/run`; use `codecov` action
 - [Tests] backport appveyor.yml
 - [Tests] add coverage for a malformed package.json
 - [Tests] only run `eclint` on intended files
 - [Tests] add coverage for absolute paths
 - [Tests] `invalid_main` fixture had an invalid "name" field
 - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `array.prototype.map`, `safe-publish-latest`, `tape`
 - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `aud`, `tape`

v1.20.0

 - [New] add `readPackage` and `readPackageSync` (#236)
 - [Deps] update `is-core-module`
 - [meta] do not publish github action workflow files
 - [meta] create SECURITY.md
 - [meta] do not fail when `aud` is running and deps are not present
 - [meta] fix indentation in lib/core.json
 - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `array.prototype.map`, `aud`, `tape`
 - [Tests] skip `npm ls` check on older nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants