Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump 3rd_party/ssplit-cpp from a08d6bc to 49fde6d #408

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 14, 2022

Bumps 3rd_party/ssplit-cpp from a08d6bc to 49fde6d.

Commits
  • 49fde6d Merge pull request #12 from abhi-agg/emsdk-version-upgrade
  • 9c9229d Fixed PCRE2_CONFIGURE_OPTIONS for CMAKE_CROSSCOMPILING_EMULATOR arguments
  • 2560002 Updated emsdk tool chain to latest tag 3.1.8
  • 49a8e12 Next attempt at fixing compilability on CentOS.
  • bf6d1e6 Prefer non-debug PCRE2 for windows vcpkg installation
  • 15ecc37 Dockerfile for testing compilation on Rockylinux.
  • 33d5e59 Make sure internal pcre2-8 library is found if used.
  • c127c14 Bug fix wrt to LIBRARY_OUTPUT_DIRECTORY.
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [3rd_party/ssplit-cpp](https://github.com/browsermt/ssplit-cpp) from `a08d6bc` to `49fde6d`.
- [Release notes](https://github.com/browsermt/ssplit-cpp/releases)
- [Commits](browsermt/ssplit-cpp@a08d6bc...49fde6d)

---
updated-dependencies:
- dependency-name: 3rd_party/ssplit-cpp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 14, 2022
@abhi-agg
Copy link
Contributor

abhi-agg commented Apr 14, 2022

@jerinphilip How about merging this one? In the meanwhile, I will figure out why #407 is failing for wasm. Most likely, emsdk upgrade in this repo (for which I will submit a PR soon) will fix it.

@jerinphilip jerinphilip merged commit f18a883 into main Apr 14, 2022
@jerinphilip jerinphilip deleted the dependabot/submodules/3rd_party/ssplit-cpp-49fde6d branch April 14, 2022 10:25
@jerinphilip
Copy link
Contributor

We will fix Broken windows workflow later (See #405 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants