Fix: 400 status code bad request in case of invalid json fetch binary URL #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamal-kaur04
changed the title
amaanbs
requested changes
Jul 24, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a 400 bad request status code issue that occurs when fetching binary URLs with invalid JSON. The main change replaces manual JSON string construction with proper JSON object handling to ensure valid JSON format.
- Replaces manual string concatenation for JSON with JSONObject for proper formatting
- Updates package version from 1.1.6 to 1.1.7 across the codebase
- Improves JSON parameter handling in the fetchSourceUrl method
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/java/com/browserstack/local/LocalBinary.java | Replaces manual JSON string construction with JSONObject for proper formatting and error handling |
| src/main/java/com/browserstack/local/Local.java | Updates package version constant to 1.1.7 |
| pom.xml | Updates Maven project version to 1.1.7 |
amaanbs
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 400 status code bad request in case of invalid json fetch binary URL