Added Gradle config support for JUnit 4 & 5 #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| run: | | ||
| cd junit-5/ios | ||
| gradle clean sampleTest | ||
| - name: Run gradle sample-local-test for junit4 ios |
There was a problem hiding this comment.
Suggested change
| - name: Run gradle sample-local-test for junit4 ios | |
| - name: Run gradle sample-local-test for junit5 ios |
README.md
Outdated
| - If Maven is not downloaded, download it from [here](https://maven.apache.org/download.cgi) | ||
| - For installation, follow the instructions [here](https://maven.apache.org/install.html) | ||
|
|
||
| 3. Gradle |
There was a problem hiding this comment.
maven and gradle should be downloaded alternatively right and presence of both is not required. Can we update th readme accordingly.
README.md
Outdated
| - Junit5 | ||
| - Update `browserstack.yml` file at root level of [Android Junit5 examples](junit-5/android) or [iOS Junit5 examples](junit-5/ios) with your [BrowserStack Username and Access Key](https://www.browserstack.com/accounts/settings) | ||
| - Run `mvn test -P sample-test` |
There was a problem hiding this comment.
inconsistency in instruction here
junit-4/android/build.gradle
Outdated
| include 'com/browserstack/LocalTest*' | ||
|
|
||
| jvmArgs "-javaagent:${configurations.testRuntimeClasspath.find { it.name.contains('browserstack-java-sdk') }}" | ||
| } No newline at end of file |
There was a problem hiding this comment.
need empty line here
junit-4/android/settings.gradle
Outdated
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
junit-4/ios/build.gradle
Outdated
| include 'com/browserstack/LocalTest*' | ||
|
|
||
| jvmArgs "-javaagent:${configurations.testRuntimeClasspath.find { it.name.contains('browserstack-java-sdk') }}" | ||
| } No newline at end of file |
junit-4/ios/settings.gradle
Outdated
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
avinash-bharti
approved these changes
Apr 3, 2025
darshilgada24
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA :- https://browserstack.atlassian.net/browse/AAP-15642
Added build.gradle and settings.gradle for gradle config
Updated Readme and workflow for steps to run tests using gradle.