Skip to content

Reverse proxy with https support #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Oct 27, 2020
Merged

Reverse proxy with https support #7

merged 45 commits into from
Oct 27, 2020

Conversation

neerajshukla1911
Copy link
Contributor

Added reverse proxy server with https support to proxy and reverse proxy

Jira Ticket: https://browserstack.atlassian.net/browse/ACE-1056

rchougule
rchougule reviewed Oct 18, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 18, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 18, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 18, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 18, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 18, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 18, 2020
View reviewed changes
@rchougule
Copy link
Contributor

rchougule commented Oct 18, 2020 •
edited
Loading

Are we going ahead with reverse proxy only? Will proxy mode work?

The behaviour of proxy seems to have changed.
All requests are being forwarded to hub and not the given URL in case of using it in proxy mode.

 ✘ chaugs_rohan@Rohans-MBP-2  ~  curl -x localhost:9687 http://google.com
{"value":{"message":"Invalid Command"}}%                                                                                                                                                                                                                                         chaugs_rohan@Rohans-MBP-2  ~ 

google.com is being routed to hub...

rchougule
rchougule reviewed Oct 18, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 18, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 18, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 18, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 18, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 21, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 21, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 21, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 21, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 21, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 21, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 21, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 21, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 21, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 21, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 21, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 21, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 21, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 23, 2020
View reviewed changes
rchougule
rchougule reviewed Oct 23, 2020
View reviewed changes
rchougule
rchougule approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@rchougule rchougule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francisf francisf merged commit c9dbc80 into browserstack:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francisf francisf francisf approved these changes

+1 more reviewer

@rchougule rchougule rchougule approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neerajshukla1911 @rchougule @francisf