Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the mac guide #322

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Improve the mac guide #322

merged 2 commits into from
Jul 27, 2020

Conversation

toyboot4e
Copy link
Contributor

@toyboot4e toyboot4e commented May 11, 2020

I tried to improve the guide:

  • fix a typo (GOROOT; it's actually GOPATH)
  • create GOPATH/bin so that we can run ./interfacer/contrib/build_browsh.sh
  • prefer to show code blocks

Edit: you can see how it changed: before, after

@toyboot4e toyboot4e changed the title Imrove the mac guidei Improve the mac guide May 11, 2020
@tombh
Copy link
Member

tombh commented Jul 27, 2020

I'm so sorry I didn't merge this sooner! Thank you very much :)

@tombh tombh merged commit 48afc96 into browsh-org:master Jul 27, 2020
@toyboot4e toyboot4e deleted the macos_guide branch August 19, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants