Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collator): use prev data accounts extra total count for finalize… #486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(collator): use prev data accounts extra total count for finalize… #486

wants to merge 1 commit into from
+44 −36

Conversation

serejkaaa512
Copy link
Contributor

… wu calculation

@serejkaaa512 serejkaaa512 force-pushed the feature/wu-merkle-update branch 6 times, most recently from a31e4de to de85403 Compare December 6, 2024 09:29
SmaGMan
SmaGMan reviewed Dec 6, 2024
View reviewed changes
collator/src/collator/do_collate/finalize.rs Outdated
} = wu_params_finalize;

let accounts_count_logarithm = accounts_count.checked_ilog2().unwrap_or_default() as u64;
let delimiter = 1000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create const instead.

SmaGMan
SmaGMan reviewed Dec 6, 2024
View reviewed changes
collator/src/collator/do_collate/finalize.rs Outdated
@@ -344,19 +344,27 @@ impl Phase<FinalizeState> {
);

let accounts_count = self.state.collation_data.accounts_count;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to rename account_count into updated_accounts_count to avoid confusion. We might mistakenly assume that this is new total accounts count in the state.

@serejkaaa512 serejkaaa512 force-pushed the feature/wu-merkle-update branch 6 times, most recently from 1ee864f to 9f0beb6 Compare December 10, 2024 06:32
@serejkaaa512 serejkaaa512 force-pushed the feature/wu-merkle-update branch from 9f0beb6 to 9e453ea Compare December 10, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmaGMan SmaGMan SmaGMan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serejkaaa512 @SmaGMan