Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(collator): fix collators lags and panics after sync #494

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

SmaGMan
Copy link
Contributor

@SmaGMan SmaGMan commented Dec 6, 2024

No description provided.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 43.84%. Comparing base (c69d94c) to head (77958bc).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
collator/src/collator/mod.rs 0.00% 8 Missing ⚠️
collator/src/manager/mod.rs 0.00% 6 Missing ⚠️
collator/src/collator/do_collate/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
- Coverage   43.84%   43.84%   -0.01%     
==========================================
  Files         269      269              
  Lines       47409    47422      +13     
  Branches    47409    47422      +13     
==========================================
+ Hits        20788    20793       +5     
- Misses      25555    25564       +9     
+ Partials     1066     1065       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SmaGMan SmaGMan force-pushed the fix/collation-lags branch from 6af5ace to 1fd7d79 Compare December 9, 2024 13:21
@SmaGMan SmaGMan changed the title fix(collator): drop accumulated used wu when no pending messages fix(collator): fix collators lags and panics after sync Dec 11, 2024
@SmaGMan SmaGMan marked this pull request as ready for review December 11, 2024 14:10
@Rexagon Rexagon added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit 91b1c8c Dec 11, 2024
8 of 9 checks passed
@Rexagon Rexagon deleted the fix/collation-lags branch December 11, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants