Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Let Abricotine open local links #317

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Conversation

seanlucrussell
Copy link

Proposal to implement feature requested in #303. shell.openItem (shell.openPath in newer versions of electron) generalizes shell.openExternal and lets the OS open local links using the appropriate application. URLs will still open as they do now, but this will also allow links to pictures, pdfs, or indeed other markdown files to open in the same way.

Tested on Ubuntu 20.04 against these test cases:

  1. [absolute path](/home/<user>/abricotine/README.md) - OPENS CORRECTLY
  2. [relative path](abricotine/README.md) - OPENS CORRECTLY
  3. [empty path]() - NOTHING OPENS AS EXPECTED
  4. [website](https://github.com/brrd/Abricotine) - OPENS CORRECTLY
  5. [website no proto](github.com/brrd/Abricotine) - OPENS CORRECTLY
  6. [bad path](nonexistent-nonsense) - NOTHING OPENS AS EXPECTED

…inks to local documents can be opened like links to external documents
@seanlucrussell
Copy link
Author

Throwing this proposal out there for three reasons:

  1. In case anyone else wants to know how to implement this feature (for personal use, for future forks, et cetera).
  2. In case the project does end up getting continued
  3. Because I didn't read the pinned issue Contributing to Abricotine #310 (whoops!) until after I'd already made the change locally and I felt like it would be too much of a shame to leave it on my personal device. I've really been enjoying Abricotine for note taking, and linking between different notes is a really handy feature.

But I also understand the reluctance to continue the project (I hate getting trapped by my old code!), so feel free to close this pr at your pleasure.

@brrd
Copy link
Owner

brrd commented Mar 23, 2022

Thank you, I'm merging this PR but I don't know when I will be able to publish a new release including this feature.

@brrd brrd merged commit 55259ae into brrd:develop Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants