Add assertion for setRewardsStore return value, update test cov report

brritoxyz · Dec 19, 2023 · c997a30 · c997a30
1 parent 80797e8
commit c997a30
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 22 deletions.
diff --git a/lcov.info b/lcov.info
@@ -19,37 +19,58 @@ BRF:0
 BRH:0
 end_of_record
 TN:
+SF:script/UpdateDynamicRewards.s.sol
+FN:21,UpdateDynamicRewardsScript.run
+FNDA:0,UpdateDynamicRewardsScript.run
+DA:22,0
+DA:24,0
+DA:29,0
+DA:34,0
+DA:35,0
+DA:37,0
+FNF:1
+FNH:0
+LF:6
+LH:0
+BRF:0
+BRH:0
+end_of_record
+TN:
 SF:src/DynamicRewards.sol
-FN:32,DynamicRewards.setRewardsStore
-FNDA:3,DynamicRewards.setRewardsStore
-DA:33,2
-BRDA:33,0,0,1
-BRDA:33,0,1,1
-DA:35,1
-DA:37,1
-FN:47,DynamicRewards.getNextCycleRewards
+FN:33,DynamicRewards.setRewardsStore
+FNDA:259,DynamicRewards.setRewardsStore
+DA:36,258
+BRDA:36,0,0,1
+BRDA:36,0,1,257
+DA:39,257
+BRDA:39,1,0,-
+BRDA:39,1,1,257
+DA:40,257
+DA:42,257
+DA:44,257
+FN:54,DynamicRewards.getNextCycleRewards
 FNDA:257,DynamicRewards.getNextCycleRewards
-DA:48,257
-FN:55,DynamicRewards.transferOwnership
+DA:55,257
+FN:62,DynamicRewards.transferOwnership
 FNDA:0,DynamicRewards.transferOwnership
-FN:57,DynamicRewards.renounceOwnership
+FN:64,DynamicRewards.renounceOwnership
 FNDA:0,DynamicRewards.renounceOwnership
 FNF:4
 FNH:2
-LF:4
-LH:4
-BRF:2
-BRH:2
+LF:6
+LH:6
+BRF:4
+BRH:3
 end_of_record
 TN:
 SF:src/RewardsStore.sol
 FN:22,RewardsStore.transferNextCycleRewards
-FNDA:515,RewardsStore.transferNextCycleRewards
-DA:23,515
+FNDA:772,RewardsStore.transferNextCycleRewards
+DA:23,772
 BRDA:23,0,0,1
-BRDA:23,0,1,514
-DA:25,514
-DA:27,514
+BRDA:23,0,1,771
+DA:25,771
+DA:27,771
 FNF:1
 FNH:1
 LF:3

diff --git a/test/DynamicRewards.t.sol b/test/DynamicRewards.t.sol
@@ -61,8 +61,11 @@ contract DynamicRewardsTest is Test, Helper {
 
  emit DynamicRewards.SetRewardsStore(_rewardsStore, nextCycleRewards);
 
- dynamicRewards.setRewardsStore(_rewardsStore);
+ uint256 retrievedRewards = dynamicRewards.setRewardsStore(
+ _rewardsStore
+ );
 
+ assertEq(retrievedRewards, nextCycleRewards);
  assertEq(_rewardsStore, address(dynamicRewards.rewardsStore()));
  assertEq(0, WETH.balanceOf(currentRewardsStore));
  assertEq(
@@ -93,8 +96,11 @@ contract DynamicRewardsTest is Test, Helper {
 
  emit DynamicRewards.SetRewardsStore(_rewardsStore, nextCycleRewards);
 
- dynamicRewards.setRewardsStore(_rewardsStore);
+ uint256 retrievedRewards = dynamicRewards.setRewardsStore(
+ _rewardsStore
+ );
 
+ assertEq(retrievedRewards, nextCycleRewards);
  assertEq(_rewardsStore, address(dynamicRewards.rewardsStore()));
  assertEq(0, WETH.balanceOf(currentRewardsStore));
  assertEq(