Skip to content

Commit

Permalink
Merge branch 'master' into stable
Browse files Browse the repository at this point in the history
  • Loading branch information
guillaume-gricourt committed Jan 30, 2023
2 parents 6f6d262 + 6fb96d1 commit 5c6af2a
Show file tree
Hide file tree
Showing 13 changed files with 723 additions and 2,712 deletions.
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,15 @@ conda install -c conda-forge pytest
python -m pytest tests
```

To run functional tests, the environment variable `RP2_FUNCTIONAL=TRUE` is required.

### Knime dependencies

Knime software and packages are available at:
* [KNIME](https://www.knime.com/)
* [KNIME v4.6.4 - Zenodo](https://zenodo.org/record/7515771)
* [KNIME v4.7.0 - Zenodo](https://zenodo.org/record/7564938)

## Known issues

1. Could not load native RDKit library, libfreetype.so.6: cannot open shared object file
Expand Down
24 changes: 12 additions & 12 deletions retropath2_wrapper/Args.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,16 @@


DEFAULT_MSC_TIMEOUT = 10 # minutes
DEFAULT_KNIME_VERSION = '4.5.0'
DEFAULT_KNIME_VERSION = "4.6.4"
DEFAULT_RP2_VERSION = 'r20220104'
KNIME_PACKAGE = {
'4.5.0': {
'org.knime.features.chem.types.feature.group': '4.5.0.v202107011901',
'org.knime.features.datageneration.feature.group': '4.5.0.v202107011901',
'org.knime.features.python.feature.group': '4.5.2.v202203041212',
'org.rdkit.knime.feature.feature.group': '4.5.0.v202207051536',
},
}
KNIME_ZENODO = {"4.6.4": "7515771", "4.7.0": "7564938"} # Map to Zenodo ID
DEFAULT_ZENODO_VERSION = "NA"
RETCODES = {
'OK': 0,
'NoError': 0,
# Warnings
'SrcInSink': -1,
'NoSolution': -2,
'SrcInSink': 10,
'NoSolution': 11,
# Errors
'FileNotFound': 1,
'OSError': 2,
Expand Down Expand Up @@ -103,7 +97,6 @@ def _add_arguments(parser):
parser.add_argument(
'--kver',
type=str,
choices=list(KNIME_PACKAGE.keys()),
default=DEFAULT_KNIME_VERSION,
help='version of KNIME (mandatory if --kexec is passed).',
)
Expand All @@ -113,6 +106,13 @@ def _add_arguments(parser):
default=False,
help='Install Knime packages (default: False).'
)
parser.add_argument(
'--kzenodo',
choices=[DEFAULT_ZENODO_VERSION] + list(KNIME_ZENODO.keys()),
default=DEFAULT_ZENODO_VERSION,
help='install Knime and its dependencies from Zenodo.'
)

parser.add_argument(
'--rp2_version',
type=str,
Expand Down
Loading

0 comments on commit 5c6af2a

Please sign in to comment.