Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rimraf to ~2.6.2 #69

Merged
1 commit merged into from
Mar 9, 2018
Merged

Update rimraf to ~2.6.2 #69

1 commit merged into from
Mar 9, 2018

Conversation

BinaryMuse
Copy link

We're seeing some process crashes using node-temp on Windows (x-ref atom/tree-view#1203). Updating to the latest rimraf seems to fix the issue. This PR updates rimraf to ~2.6.2, the current latest release.

@BinaryMuse
Copy link
Author

I just noticed that there is #55, which this PR would supercede.

@daviwil
Copy link

daviwil commented Feb 16, 2018

Hi @bruce, any chance of getting this merged and a new node-temp update shipped? This fix will help unblock Atom's CI tests on Windows so it would be greatly appreciated! Let me know if there's anything else we should do.

/cc @kuychaco

@winstliu
Copy link

Also /cc @MiguelSolano.

@daviwil
Copy link

daviwil commented Feb 22, 2018

We've forked node-temp (temporarily?) so that we could take this change to unblock our test failures. You can find it on GitHub (atom/node-temp) and npm (@atom/temp).

@ghost
Copy link

ghost commented Mar 9, 2018

@daviwil Just got done checking this out. A release should be coming out soon, I just need @bruce to allow me to take over releases.

@ghost ghost merged commit 489942b into bruce:master Mar 9, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants